aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
437 stars 192 forks source link

Add `verdi storage version|status` #6547

Closed danielhollas closed 3 months ago

danielhollas commented 4 months ago

For your use case [in AiiDAlab container deployment], I imagine it would be even better if there would simply be an endpoint that would check whether the storage is up to date or needs migrating. I think we could either add this to verdi storage version and have it actually validate the storage and return a specific exit code if it needs to be migrated, or we could add verdi storage status or something like that. These commands wouldn't have to check whether the daemon is running so could be made faster.

Originally posted by @sphuber in https://github.com/aiidateam/aiida-core/issues/6546#issuecomment-2247076753

danielhollas commented 4 months ago

@sphuber I like the idea of a new command instead of adding an extra logic to verdi storage migrate. Do you think this is something that could get into a patch release so that @superstar54 et al could you it for the QeApp demo server?

I think this might cut around 1.5s from the container startup (i.e. 10%). cc @giovannipizzi

sphuber commented 4 months ago

@sphuber I like the idea of a new command instead of adding an extra logic to verdi storage migrate. Do you think this is something that could get into a patch release so that @superstar54 et al could you it for the QeApp demo server?

Could do yeah

danielhollas commented 4 months ago

Wait, is that a British "could do"? :thinking: :smile:

image

sphuber commented 4 months ago

Haha 😄 nah, I am way too Dutch and direct for that to be a subtle refusal

image