aikaterna / gobcog

RPG Adventure Cog for Red v3
44 stars 68 forks source link

[Bug] Tinker 2h item duplication #356

Open aikaterna opened 3 years ago

aikaterna commented 3 years ago

Complete these first

Expected Behavior

Tinkers should only have one copy of their item

Current Behavior

This is 3.4.4 (PR)

See attachments where Axas has his apocolypse staff equipped and also in the backpack.

stats

backpack

There is also another user with 8x of their tinker item in their backpack currently.

Possible Solution

Not sure what's going on here. Haven't caught a duplication yet so not sure what triggers it. Seems like it's rebirth related. Possibly related to https://github.com/aikaterna/gobcog/blob/7721dbfb96622d84ceb3e0dc8c7b60e13a592423/adventure/charsheet.py#L1631-L1647

Steps to Reproduce

  1. Rebirth with a 2 handed tinker weapon.

Context (Environment)

It's not hurting anything (yet) but it's causing questions.

Detailed Description

The tinker item should only be in one place at a time. No interdimensional tinker items please.

Possible Implementation

Magic. Specifically Draper magic. Also Axas' answer in https://discord.com/channels/154659242253484033/154659242253484033/808481778582552596

aikaterna commented 3 years ago

This apparently also affects 2h weapons for classes other than tinker as well on rebirth. Had an item duplicate when rebirthing after having it equipped.