search

aikoven / typescript-fsa

Type-safe action creator utilities
MIT License
607 stars 28 forks source link

Optional parameters not respected in 3.0.0 #79

Closed anodynos closed 5 years ago

anodynos commented 5 years ago

When I upgrade from 3.0.0-beta-2 to 3.0.0 I'm getting loads of

error TS2554: Expected 1-2 arguments but got 0.

for all my actionFactory<void> & actionFactory.async<void, SomeType>.

Reverting back to 3.0.0-beta-2 solves it. I'm on TypeScript 3.1.6.

aikoven commented 5 years ago

Can you please provide some code to reproduce?

anodynos commented 5 years ago

Sorry I've missed that, was busy/holidays :-) I will do when I find some time next week...

anodynos commented 5 years ago

Closing this - I can't reproduce it any more (we've upgraded to TypeScript 3.5.3 since, maybe that has solved it, not sure ;-) )

Thanks for the lib, it rocks ;-)