ailijic / easy-slow-down-manager

Automatically exported from code.google.com/p/easy-slow-down-manager
0 stars 0 forks source link

Cannot change my brightness level to below 10 #12

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Hi
I've upgraded the driver lately and 
it looks like I cannot change my brightness level to below 10 any more (in pci 
mode).
And the reason is probably here:

  if(minbright<MIN_BRIGHT)
     minbright=MIN_BRIGHT;  // MIN_BRIGHT = 0x0A

Why is it that you prohibited any levels below 10?
I personally prefer to keep my brightness at around 2-5
(and that was working nicely in the older versions).

Here is a suggestion:
How about if you set the _default_ min brightness to 10,
but let people change it to whatever they like via module parameters?

In other words, set
  static int minbright = MIN_BRIGHT;
and remove the above 
  if(minbright<MIN_BRIGHT)
     minbright=MIN_BRIGHT;

Then normal people will get a reasonable default behaviour
but someone who really wants to (me) can increase the brightness range as well.

What version of the product are you using? On what operating system?

Kubuntu 11.04 natty
Samsung N140
package from voRia: samsung-backlight - 0.13.7~ppa3~loms~natty  (based on r33 
of the driver)
options samsung-backlight use_sabi=0 levels=50 force=1

PS great work btw, thanks for this driver, it's working flawlessly for me 
otherwise.

Original issue reported on code.google.com by mikeblma...@yahoo.ie on 15 May 2011 at 9:04

GoogleCodeExporter commented 9 years ago
ok, I'll lower minimum level of brightness soon

Original comment by SergeyK...@gmail.com on 15 Jun 2011 at 8:46

GoogleCodeExporter commented 9 years ago
minbright<10 are allowed now; 
personally, I do not see any reason for such low levels (better to switch off 
the display)

Original comment by SergeyK...@gmail.com on 1 Feb 2012 at 1:21