search

aimacode / aima-javascript

Javascript visualization of algorithms from Russell And Norvig's "Artificial Intelligence - A Modern Approach"
http://aimacode.github.io/aima-javascript/
MIT License
544 stars 219 forks source link

Ch 5. Adversarial Search: Expectiminimax tree #153

Closed Dragneel7 closed 5 years ago

Dragneel7 commented 6 years ago
Dragneel7 commented 6 years ago

@samuelgoto Hi, can you please review the PR. Thanks.

samuelgoto commented 6 years ago

Is there a reason this needs to be checked in in the main branch? Can you point me to a demo page before we check this in?

On Thu, Feb 22, 2018 at 2:20 PM, surya saini notifications@github.com wrote:

@samuelgoto https://github.com/samuelgoto Hi, can you please review the PR. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aimacode/aima-javascript/pull/153#issuecomment-367842180, or mute the thread https://github.com/notifications/unsubscribe-auth/AAqV6lX7JEkgOoOcCosLoXTU-mRF5ETgks5tXegSgaJpZM4SQFGe .

-- f u cn rd ths u cn b a gd prgmr !

Dragneel7 commented 6 years ago

Sure I will host it on a GH page and share it with you.

Dragneel7 commented 6 years ago

https://dragneel7.github.io/ I have hosted a demo of the visualizations with the work of the other PR's that I have added. Please have look at them, and suggest any changes if they need to be made. The visualizations are under "blog" subheading. Thanks.

samuelgoto commented 6 years ago

I took a look at the explanations and I'm wondering what's the narrative here. I wrote down some design patterns of good interactive explanations here, care to take a look?

Procedurally, I'm hoping we can spend more time discussing the design of this chapter (hint: that's the hard part) rather than its implementation (e.g. code or this PR, hint: that's the easy part).

I'm thinking that it would be more constructive if you followed this process and kicked off a google doc instead to form a narrative where I could review your design first (before getting into code, and this PR specifically).

Would that work for you?

@redblobgames in case he has further suggestions on how to go about things

Dragneel7 commented 6 years ago

I have shared a link with you regarding the same. here Please have a look at it.

samuelgoto commented 6 years ago

Done. Making comments directly into your doc.

redblobgames commented 5 years ago

I'm closing this. It looks like two different people were working on incompatible changes in chapter 5. For 2019, the guideline will be that GSoC applicants should not work on contributing changes prior to GSoC, but instead build a separate page as sample work.