search

aimeos / ai-admin-jqadm

Aimeos e-commerce Vue.js+Bootstrap based admin interface
https://aimeos.org
GNU Lesser General Public License v3.0
177 stars 43 forks source link

In BE, Moving a category to first position in cat tree not possible #118

Closed rowild closed 4 years ago

rowild commented 4 years ago

In the BE, having a category tree like the one shown in the screenshots, it is not possible to move any category to the very first place in the category tree. Instead, after save/reload the category will always be placed as the very last one.

(It works, when moved to the 2nd place.)

TYPO3 9.5.19, aimeos 20.4, php 7.3.18

move-cat

rowild commented 4 years ago

EDIT: I assume this is the wrong place to post this issue - would aimeos-jqadm be more appropriate?

aimeos commented 4 years ago

This is the behavior of the jqtree library that may differ from TYPO3 but is not a problem

rowild commented 4 years ago

What? Why is this not a problem? What about UI/UX?

aimeos commented 4 years ago

You can move the categories to the first place but you have to moved the mouse pointer between the root node and the first entry until the line between both items appear that shows the the node will be inserted there. It's not possible to drop the node at the root node and expect that it's inserted at the first place

rowild commented 4 years ago

Please have a look at my screenshots: from what I see, the right half shows a correct positioning of "Körpertheater". Why shouldn't it stay there, if it shows the correct positioning? And even if, why , if not possible to be put as the first category in list, is it afterwards moved to the last position?

These problems do not appear, when moving to another (second, third, ...) position. IMO, if there is a problem with the first position, there should be at least some kind of visible/informational feedback.

But to say "this is not a problem" is by all means not true, if I may say so.

aimeos commented 4 years ago

OK, now I see. You moved the node to the first position and it was placed correctly but after reloadin the page, the change was not saved. Sorry for the misunderstanding. I can confirm that this is a problem and have to investigate what happens here.

rowild commented 4 years ago

BTW: this is true for all first-position options, even for deeper sub levels...

aimeos commented 4 years ago

Yes, it happens in subcategories too

aimeos commented 4 years ago

The problem is fixed in dev-master, 2020.04.x-dev and 2019.10.x-dev. Can you confirm?

rowild commented 4 years ago

I can confirm that your solution works fine for both 20.4 and "2019.10.x-dev as 19.10.7" (via aimeos distribution).

Thank you very much!!! The fix looks way more complex then I have imagined!!

Is there anywhere a review place, where I should place a "+1"?

aimeos commented 4 years ago

All fine, thank you very much for your help! :-)