search

aimeos / ai-admin-jqadm

Aimeos e-commerce Vue.js+Bootstrap based admin interface
https://aimeos.org
GNU Lesser General Public License v3.0
177 stars 43 forks source link

Tackle flickering #127

Closed rowild closed 4 years ago

rowild commented 4 years ago

The new mobile layout contributions cause flickering in desktop state, because the sidebar is not equal-height with the content area. This fix tries to solve that. Currently only tested in TYPO3, but there seems to be a distance on the top of the sidebar nav in Laravel, which I haven't setup yet. (Will do, but maybe in the meantime somebody can test on Laravel... and in general...? Thank you!)

rowild commented 4 years ago

display: flex in combination with position: absolute behaves weird within the TYPO3 iframe, it simply won't stretch to the bottom. Fixing the display for TYPO3 breaks the one for Laravel and veice versa.

All I can think of is making the sidebar-nav position:fixed;overflow-y:scroll, so that it behaves independently from the content area. That would work in both TYPO3 and Laravel. Width a little bit of native scrollbar styling, this would look ok. Maybe even put the scrollbar on the child container, so the logo - and therefor the top bar in laravel (where the Logout button sits) - is not distracted / visually "separated" by a scrollbar. I don't know if this is something you would like...

Otherwise I am out of ideas and would rather vote for a complete undo/revert of all of my commits.

aimeos commented 4 years ago

Do the first two commits fix the flickering problem? If yes, we would like to merge them even if the height problem is not totally fixed yet. For that, you have to revert your last commit and push that change. Thanks

rowild commented 4 years ago

Wouldn't it be better to include the Laravel hack instead of just delivering the flickering?

To my understanding the logout button would only then be bigger, when an implementer/developer overrides the delivered CSS. At this point it would be fair to assume that the developer can also override the hack to adapt the distance to the top of the main sidebar.

But if no changes are made, it simply works.

Maybe I am missing something here...?