aio-libs / aiopg

aiopg is a library for accessing a PostgreSQL database from the asyncio

http://aiopg.readthedocs.io

BSD 2-Clause "Simplified" License

1.39k stars 159 forks source link

Fix compatibility with SQLAlchemy >= 1.4 #870

Closed decaz closed 3 years ago

decaz commented 3 years ago

What do these changes do?

Fix compatibility with SQLAlchemy >= 1.4.

Are there changes in behavior for the user?

Related issue number

Fixes #869.

Checklist

[x] I think the code is well written
[x] Unit tests for the changes exist
[ ] Documentation reflects the changes
[ ] Add a new news fragment into the CHANGES folder
- name it <issue_id>.<type> (e.g. 588.bugfix)
- if you don't have an issue_id change it to the pr id after creating the PR
- ensure type is one of the following:
- .feature: Signifying a new feature.
- .bugfix: Signifying a bug fix.
- .doc: Signifying a documentation improvement.
- .removal: Signifying a deprecation or removal of public API.
- .misc: A ticket has been closed, but it is not of interest to users.
- Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

Pliner commented 3 years ago

Thanks for your contribution. I will be able to review PR tomorrow.

codecov[bot] commented 3 years ago

Codecov Report

Merging #870 (7fc3643) into master (10071ff) will decrease coverage by 0.03%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
- Coverage   93.36%   93.32%   -0.04%     
==========================================
  Files          11       12       +1     
  Lines        1568     1574       +6     
  Branches      186      187       +1     
==========================================
+ Hits         1464     1469       +5     
  Misses         73       73              
- Partials       31       32       +1

Impacted Files	Coverage Δ
aiopg/sa/result.py	`90.47% <50.00%> (-0.31%)`	:arrow_down:
aiopg/sa/utils.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10071ff...7fc3643. Read the comment docs.

decaz commented 3 years ago

@Pliner yes, I also added test for this exception. I think it will be nice to include SQLAlchemy version in CI job matrix in the future for testing against ==1.3 and >=1.4 versions.

Pliner commented 3 years ago

@Pliner yes, I also added test for this exception. I think it will be nice to include SQLAlchemy version in CI job matrix in the future for testing against ==1.3 and >=1.4 versions.

Cool.

If you have time and you know how to do this, feel free to create a PR.

Pliner commented 3 years ago

https://pypi.org/project/aiopg/1.3.2b1/

Pliner commented 3 years ago

@decaz Have you had a chance to test this version in a production environment?

decaz commented 3 years ago

@Pliner not yet, - I'm trying to migrate my code base from SQLAlchemy 1.3 to 1.4 and while I run tests now there is no errors related to string_or_unprintable. But there are errors related to #798 :(