search

air-verse / air

☁️ Live reload for Go apps
GNU General Public License v3.0
16.32k stars 770 forks source link

Implement graceful shutdown on Mac #618

Closed xiantang closed 1 week ago

xiantang commented 1 week ago

close https://github.com/air-verse/air/issues/534

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files Coverage Δ
runner/engine.go 71.13% <100.00%> (+4.46%) :arrow_up:

... and 2 files with indirect coverage changes

ccoVeille commented 1 week ago

So it's about

Easier for everyone, and allow crossing issue and PR

ccoVeille commented 1 week ago

Title is not used for resolving and quoting issues and PR relationship.

Especially there were you used an URL and not an hash (and I'm unsure it would have worked anyway)

Description and comments are the perfect candidates when dealing with GitHub relationship

xiantang commented 1 week ago

Title is not used for resolving and quoting issues and PR relationship.

Especially there were you used an URL and not an hash (and I'm unsure it would have worked anyway)

Description and comments are the perfect candidates when dealing with GitHub relationship

gotcha, thank you

ccoVeille commented 1 week ago

PR superseeded and replaced by #619