search

airbnb / DeepLinkDispatch

A simple, annotation-based library for making deep link handling better on Android
http://nerds.airbnb.com/deeplinkdispatch/
4.37k stars 409 forks source link

queryParameterValue must not be null #351

Open masonHong opened 2 years ago

masonHong commented 2 years ago

I was using version 5.4.3, but when I upgraded to version 6.1.0, a crash occurred, so I checked it.

Fatal Exception: java.lang.NullPointerException: queryParameterValue must not be null
       at com.airbnb.deeplinkdispatch.BaseDeepLinkDelegate.queryAndPathParameters(BaseDeepLinkDelegate.java:530)
       at com.airbnb.deeplinkdispatch.BaseDeepLinkDelegate.createResult(BaseDeepLinkDelegate.java:286)
       at com.airbnb.deeplinkdispatch.BaseDeepLinkDelegate.dispatchFrom(BaseDeepLinkDelegate.java:70)
       at com.airbnb.deeplinkdispatch.BaseDeepLinkDelegate.dispatchFrom$default(BaseDeepLinkDelegate.java:64)

When I reproduced it, a crash occurs when Uri of the pattern below is used.

Uri have a query with no value or with ? but no query.

Can you fix the problem?

jackcsk commented 1 year ago

@EricKuck are we expecting a new release including that fix soon?

EricKuck commented 1 year ago

I am not a maintainer on this project. Can't say if/when a new release is coming out.

jackcsk commented 1 year ago

My bad, sorry Eric.

jackcsk commented 1 year ago

@rossbacher : not sure if you are the right person to address to, or please help me to refer to the right person Wanna know when this fix will be included in the new release