Closed fbertos closed 1 year ago
@fbertos I think we can add a new template file for each of these resources, so people are able to set the apiVersion
with a helm value depending on what Kubernetes version they are using.
PodDisruptionBudget
policy/v1beta1
policy/v1
HorizontalPodAutoscaler
autoscaling/v2beta2
autoscaling/v2
We already have a very similar thing for Ingress, and the ingress.apiVersion
value:
Obviously, if there is no actual difference between the apiVersions
(need to confirm), this change will be very simple.
Also, our default helm values should set the apiVersion
which supports the current most common version of Kubernetes in use.
Hi @thesuperzapper, great, that would be perfect. Thanks!
@thesuperzapper hey, I believe I have fixed this issue with #685, do you think we can get v8.7.0 released only with this fix?
I'd really like to avoid forking or overriding the templates in some other ways to get this one working on my infra, it'd be helpful for me if we could get it going with as low effort from your side as possible.
@karakanb I agree that we should get this fix out ASAP, I have done a review of your PR, but it needs some small changes, see: https://github.com/airflow-helm/charts/pull/685#pullrequestreview-1286232585
+1 Waiting for that.
Checks
User-Community Airflow Helm Chart
.Motivation
Hi,
We would like to deploy Airflow v2.3.3 with Chart version 8.6.1 on Kubernetes 1.23.12 with the following worker configuration:
However it is not working correctly and we receive this warning:
Implementation
To change the templates of the worker:
worker-hpa.yaml
worker-pdb.yaml
To use the API version
policy/v1
andautoscaling/v2
for these specs.Are you willing & able to help?