search

airr-community / rep-cred

SW Tools Group - Repertoire Credibility Tool
Creative Commons Attribution 4.0 International
0 stars 3 forks source link

change R package installation method in the container #43

Closed ssnn-airr closed 4 months ago

ssnn-airr commented 4 months ago

Failed installations with Rscript result in a warning, not an error, and the build continues even the installation of dependencies failed. Maybe try the install2.r script that comes with rocker. And update tests to verify the installation was successful.

ssnn-airr commented 4 months ago

I decided to simply add require (e9bd37d7394b553b0ae276a8ff2829b56764afed) to check that the packages are installed.

ssnn-airr commented 4 months ago

Reviewing the docs, require throws just a warning, so it won't stop the build process. I will change to library.

williamdlees commented 4 months ago

Ah, that’s what it was.

Shall I change the github and docker names? As I recall the old github name will continue to work, if people have a repo checked out

William

From: ssnn @.> Sent: Wednesday, July 10, 2024 9:12 AM To: airr-community/rep-cred @.> Cc: Subscribed @.***> Subject: Re: [airr-community/rep-cred] change R package installation method in the container (Issue #43)

I decided to simply add library ( https://github.com/airr-community/rep-cred/commit/e9bd37d7394b553b0ae276a8ff2829b56764afed e9bd37d) to check that the packages are installed.

— Reply to this email directly, view it on GitHub https://github.com/airr-community/rep-cred/issues/43#issuecomment-2219838592 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXBI7LDLZKOJWQRCGVO62LZLTUDNAVCNFSM6AAAAABKTI6MZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJZHAZTQNJZGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>