Add social text, test - Githubissues

ajam / pulp

A vivacious viewer for web comics.

http://ajam.github.io/pulp

MIT License

89 stars 17 forks source link

Add social text, test #22

Closed mhkeller closed 10 years ago

mhkeller commented 10 years ago

A few things need little tweaks before publication

[x] Social buttons populate with proper text with appropriate behavior for
- [x] mobile
- [x] desktop
[x] Higher quality icon font for toolbar buttons. These aren't crisp enough. GitHub fonts are really nice. Look into whether they have the proper icons.
[x] Header dropdown tooltips need to be standardized and made nicer

mhkeller commented 10 years ago

Re: icon font. Book looks good for endnotes, or the ul, ol icons. They have a hamburger. I like their cloud with an arrow for downloading to use for other formats.

They don't have social icons but those are gettable. They don't have a sharing or fullscreen icon.

Icomoon has social + those two. Will test. https://icomoon.io/app/#/select/font

mhkeller commented 10 years ago

Went with some the icons, changed font size and replaced download since octicon wasn't looking much better.

Buttons and dropdowns look much nicer now: https://github.com/ajam/pulp/commit/5ba960401c4b3c81011bbd8e0151f0cf8572cc33

mhkeller commented 10 years ago

Social buttons mostly done: https://github.com/ajam/pulp/commit/71a00e9b176d32bff1b07350c65eb9d496dc390d

Needs final testing with final text.