search

ajwdewit / pcse_notebooks

A collection of Jupyter notebooks that demonstrate usage of PCSE
MIT License
116 stars 72 forks source link

Inconsistency in the manuals regarding SMLIM; YAML soil files #13

Closed pedroalencar1 closed 2 years ago

pedroalencar1 commented 2 years ago

Hi there, many thanks for creating this material. Apologies, I am not sure if this is the proper channel to report this

Reading the manuals (https://www.wur.nl/en/show/A-gentle-introduction-to-WOFOST.htm) in two points SMLIM is said to be in centimetres, however from the source code it appears to be cm3.cm-3. Which is the correct?

Additionally, would it be possible to have a YAML soil reader/provider? I find yaml files easier to work with. In my own implementations I am already using YAML files for soils that I created yaml_soil.zip

Cheers

ajwdewit commented 2 years ago

Hi Pedro,

Is this still relevant? I see it dates from before my holiday and I've missed the issue on github. Sorry for that.

Allard

pedroalencar1 commented 2 years ago

Hi Allard,

thanks for getting back. I believe SMLIM is in cm3/cm3, as all other SM* variables. Just wanted to alert on the small error because when I first read it made me fear I was doing it all wrong :)

Also about the yaml, I just wanted to contribute somehow, but is not really relevant. I prefer to have the data in yaml rather than the old *.NEW. I already wrote a simple function to work with the soil yaml files.

cheers,

pedro

ajwdewit commented 2 years ago

Hi Pedro,

Thanks for notifying this. We will correct it in the next update of the document.

We are working on a new waterbalance as well, that waterbalancewill have soil inputs in YAML it will be an upcoming feature.

with best regards

Allard