ak2yny / Official-Character-Pack-v2-for-Ultimate-Alliance

Official Characters Pack (OCP) for Marvel Ultimate Alliance (MUA) was created to add the DLC content of the Xbox 360 verison to the original PC version ported by Beenox in 2006.
7 stars 0 forks source link

Combat music issues #47

Open JordanLeich opened 1 year ago

JordanLeich commented 1 year ago

Report by Cyborg Sun & updates by BloodyMares (and others)

* Needs to be tested with combat music on (might be different with ambient). The issue doesn't exist on consoles. It's possible that we can't do anything about it. Possible solutions: reduce the volume of the music (need the original music tracks); change the music override code.

Entries starting with a question mark haven't been reported and might be good. These may provide some insight as to how to fix the issues.

ak2yny commented 1 year ago

Thank you. It's good to have them listed. Videos or sound files would be helpful. The only music that I'm aware of, is the Pitfall music. Music volumes are inconsistent with stingers, and during conversations (combat music). This is mostly intentional.

JordanLeich commented 1 year ago

Water bucket music bug fixed in the Great Forge in https://github.com/ak2yny/Official-Character-Pack-v2-for-Ultimate-Alliance/commit/d2c71a2ed7995e460853888c2f86e4447e627c54

ak2yny commented 1 year ago

I listened to the cauldron music change asgard_x. It is supposed to change the music. This is by design. It changes to forced ambient. The OCP should not change that, it should be up to the user to decide to keep the combat music. The hash works as asgard_x, even though it's inconsistent.

ak2yny commented 1 year ago

The Asgard music change after using the cauldron is a music override. I found a bad music override in the Kraken fight. The conversation can barely be heard. I changed the override to later. If anyone finds a problematic music, please check for such overrides: setMusicOverride.

ak2yny commented 11 months ago

I listened to the cauldron music change asgard_x. It is supposed to change the music. This is by design. It changes to forced ambient. The OCP should not change that, it should be up to the user to decide to keep the combat music. The hash works as asgard_x, even though it's inconsistent.

I haven't thought of this earlier, but the override is only a stereo track. If it'd be a standard music track with 4 channels, it could theoretically be fixed. However, Outsider already tried using a 4 channel track for music override, IIRC. So this might not work.

The music volume seems to be controlled by the sound flags (255 by default) among other things. The music overrides from the Murderworld mini games seem to work. By checking the details of these, we might be able to get other overrides to work better.

Files from console versions might help as well.

ak2yny commented 8 months ago

Here's a complete list of all music override scripts, most with turn off scripts "" (and some might be unused):

act1\atlantis\atlantis1\down_to_atlantis.py:20:setMusicOverride("Music/sea1_x", 1.000 )
act1\atlantis\atlantis4\boss_arena_in.py:14:setMusicOverride("music/sea4_x", 1.000 )
act1\atlantis\atlantis4\boss_arena_out.py:8:setMusicOverride("", 1.000 )
act1\atlantis\atlantis4\boss_intro.py:5:setMusicOverride("music/sea4_x", 1.000 )
act1\atlantis\atlantis5\challenge_win.py:64:     setMusicOverride("", 1.000 )
act1\atlantis\atlantis5\enter_kraken_arena.py:24:     setMusicOverride("music/sea5_x", 1.000 )
act1\heli\heli3\wind_off.PY:2:setMusicOverride("", 1.000 )
act1\heli\heli3\wind_on.PY:2:setMusicOverride("music/heli3_x", 1.000 )
act1\heli\heli4\fff_pain.PY:66:               setMusicOverride("", 1.000 )
act1\heli\heli4\from_deck.py:33:     setMusicOverride("", 1.000 )
act1\heli\heli4\to_deck.py:11:     setMusicOverride("Music/heli4_x", 1.000 )
act1\mandarin\mandarin2\gg_arena_in.py:8:setMusicOverride("music/china2_x", 1.000 )
act1\mandarin\mandarin2\gg_arena_out.py:7:setMusicOverride("", 1.000 )
act1\mandarin\mandarin2\grey_defeat.py:4:setMusicOverride("", 1.000 )
act1\mandarin\mandarin2\grey_meet.py:6:setMusicOverride("music/china2_x", 1.000 )
act1\omega\omega4\modok_arena_in.py:11:setMusicOverride("music/omega4_x", 1.000 )
act1\omega\omega4\modok_arena_out.py:10:setMusicOverride("", 1.000 )
act1\omega\omega4\modok_death_script.py:3:setMusicOverride("", 1.000 )
act1\omega\omega4\modok_defeated.py:3:setMusicOverride("", 1.000 )
act1\omega\omega4\modok_intro.py:3:setMusicOverride("music/omega4_x", 1.000 )
act2\mephisto\mephisto3\blackheart_arena_in.py:8:setMusicOverride("music/mef3_x", 1.000 )
act2\mephisto\mephisto3\blackheart_arena_out.py:7:setMusicOverride("", 1.000 )
act2\mephisto\mephisto3\blackheart_death.py:14:     setMusicOverride("", 1.000 )
act2\mephisto\mephisto3\blackheart_intro.py:7:setMusicOverride("music/mef3_x", 1.000 )
act2\murder\murder2\enter_pitfall.py:12:setMusicOverride("music/toy2_x", 2.000 )
act2\murder\murder2\pitfall_win_new.py:32:     setMusicOverride("", 2.000 )
act2\murder\murder2\pitfall_win_new.py:48:     setMusicOverride("", 2.000 )
act2\murder\murder4\bumper_start.py:62:setMusicOverride("music/toy4_x", 2.000 )
act2\murder\murder4\golden_ticket.py:14:setMusicOverride("", 2.000 )
act2\murder\murder4\ticket_spawn.PY:68:     setMusicOverride("", 2.000 )
act2\murder\murder5\boss_intro.PY:23:     setMusicOverride("music/toy5_x", 1.000 )
act2\murder\murder5\breakout_cam.py:5:setMusicOverride("music/toy5_s", 2.000 )
act2\murder\murder5\breakout_cam_off.py:6:setMusicOverride("", 2.000 )
act2\murder\murder5\breakout_finger.py:3:setMusicOverride("", 2.000 )
act3\asgard\asgard1\boss_spawn.py:6:     setMusicOverride("music/asgrd1_x", 1.000 )
act3\asgard\asgard1\ench_exec_death.py:3:setMusicOverride("", 1.000 )
act3\asgard\asgard1\in_arena.py:10:setMusicOverride("music/asgrd1_x", 1.000 )
act3\asgard\asgard1\out_arena.py:8:setMusicOverride("", 1.000 )
act3\asgard\asgard3\asgard3.py:43:     setMusicOverride("music/asgard3_x", 1.000 )
act3\asgard\asgard3\cauldron_complete.py:34:     setMusicOverride("music/asgard3_x", 1.000 )
act3\niffleheim\niffleheim4\lokitransform.py:11:setMusicOverride("music/boss3b_x", 1.000 )
act4\shiar\shiar2\gladiator_defeated.py:30:setMusicOverride("", 1.000 )
act4\shiar\shiar2\gladiator_intro.py:6:     setMusicOverride("music/shiar2_x", 1.000 )
act4\shiar\shiar4\deathbird_done.PY:10:setMusicOverride("", 1.000 )
act4\shiar\shiar4\deathbird_intro.py:5:setMusicOverride("music/shiar4_x", 1.000 )
act4\skrull\skrull4\titannus_defeated.py:4:setMusicOverride("", 1.000 )
act4\skrull\skrull4\titannus_intro.py:5:     setMusicOverride("music/skrul4_x", 1.000 )

To get this, run the following powershell command in the scripts folder:

dir -s | select-string "MusicOverride"