search

akaps / hanabi_ai

AI competition of the card game Hanabi, where the best AI is measured as the most cooperative and contributes to the highest scoring games
MIT License
1 stars 2 forks source link

Linter: relative-import #117

Closed akaps closed 5 years ago

akaps commented 5 years ago

Describe the bug We had to disable the relative-import rule from the linter, since we violate the rule in the current project

To Reproduce

  1. remove relative-import from the disabled set of rules in .pylintrc
  2. run `pylint hanabi_ai

Expected behavior pylint comes back clean, 10/10 score

Additional context Have tried this a few times, and run into an issue with example_discarder If the module uses absolute paths, running the scripts fail due to invalid imports (tests pass) If the module uses relative paths, running the tests fail to to invalid imports (scripts pass)

akaps commented 5 years ago

Should be trivial once #119 is resolved