search

akiradeveloper / dm-writeboost

Log-structured Caching for Linux
GNU General Public License v2.0
123 stars 19 forks source link

change ACCESS_ONCE() to read_once() #191

Closed allenjhan closed 6 years ago

allenjhan commented 6 years ago

I've never contributed to a Github project before, so I am sorry if I am missing something.

I updated the version to 2.2.9, and changed all use of ACCESS_ONCE() to the macro read_or_access_once(). I tested the changes by running Postmark on the mapped device in Linux v4.15.3 and v4.10.0.

akiradeveloper commented 6 years ago

@allenjhan Good work. But please

  1. don't change Makefile and ChangeLog
  2. rename read_or_acccess_once to read_once
  3. send PR to for-2.2.9 branch (don't send it directly to master)
akiradeveloper commented 6 years ago

but I still wonder if it's better to use READ_ONCE from 4.15 or older version like 3.19 that I see the macro exists. As it's just a int, ACCESS_ONCE is enough though.

allenjhan commented 6 years ago

Okay, I made the requested changes and tested on kernel versions 4.10 and 4.15. Let me know if I missed something. Thanks

akiradeveloper commented 6 years ago

@allenjhan it's much better now but please remove v2.2.9 from the commit log.

allenjhan commented 6 years ago

Done. Let me know if you need me to change anything else

allenjhan commented 6 years ago

I just removed the "d" from the end of "change" in the commit log.