akopachov / flipper-zero_authenticator

Software-based TOTP/HOTP authenticator for Flipper Zero device.
GNU General Public License v3.0
579 stars 26 forks source link

[FEATURE] Publish to OFW catalog #160

Closed akopachov closed 1 year ago

akopachov commented 1 year ago

@ClaraCrazy - shoot me but I'll still try to bypass all that crap with manifests

akopachov commented 1 year ago
12:56:00.899 [I] Working in 'C:\Users\alexk\AppData\Local\Temp\tmpts54h22u'
12:56:00.901 [I] Loaded app manifest from applications\Tools\totp\manifest.yml
12:56:00.901 [I] Cloning https://github.com/akopachov/flipper-zero_authenticator.git to C:\Users\alexk\AppData\Local\Temp\tmpwkvdw1q0
12:56:03.111 [I] Cloned
12:56:03.215 [I] Checked out commit 3569c9dff6db26ddd0e846b256d4cf1d997f729f
12:56:03.215 [I] Moving C:\Users\alexk\AppData\Local\Temp\tmpwkvdw1q0\totp to C:\Users\alexk\AppData\Local\Temp\tmpts54h22u\code
12:56:03.216 [I] Linting
12:56:04.965 [I] Building
C:\Users\alexk\AppData\Local\Temp\tmpts54h22u\code\workers\bt_type_code\bt_type_code.c:4:10: fatal error: bt/bt_service/bt_i.h: No such file or directory
    4 | #include <bt/bt_service/bt_i.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
C:\Users\alexk\AppData\Local\Temp\tmpts54h22u\code\ui\scenes\add_new_token\totp_input_text.c:2:10: fatal error: gui/view_i.h: No such file or directory
    2 | #include <gui/view_i.h>
      |          ^~~~~~~~~~~~~~
compilation terminated.
scons: *** [C:\Users\alexk\.ufbt\build\totp\ui\scenes\add_new_token\totp_input_text.o] Error 1
scons: *** [C:\Users\alexk\.ufbt\build\totp\workers\bt_type_code\bt_type_code.o] Error 1
Traceback (most recent call last):
  File "C:\Workspace\Projects\flipper-application-catalog\tools\bundle.py", line 334, in _build_sources

Heck no.

Don't want to mess with this crap any more.

ClaraCrazy commented 1 year ago

nono, you totally should bypass @flipperdevices goofy ah manifest stuff. It makes no sense to have multiple, especially given that most of the fields are duplicates. The correct solution would be to extend the manifest and make it optional for catalog compatibility.

Same way you shouldnt have to PR for every update, thats not how github should work...

akopachov commented 1 year ago

Okay, you proved me. Spent another couple of hours to bypass all the crap. Thanks Clara.