search

akshay2000 / XBMCRemoteRT

XBMC Remote for Windows and Windows Phone
24 stars 18 forks source link

Added Count to Opacity converter and added null checking to StringToImageBrushConverter. Also finished Music Pages #18

Closed gabrielsadaka closed 10 years ago

gabrielsadaka commented 10 years ago

Added Count to Opacity converter so in the semantic zoom the letter will be faded if there are no items in the group so the user can visualise which groups have items easily.

Added null checking to StringToImageBrushConverter because it was breaking if the url was null or empty string.

Finished the album, artist and all music page. Just needs styling now

akshay2000 commented 10 years ago

I don't suppose the URL would ever be null. But what happens when it's an empty string? Nothing, exception, total app crash?

gabrielsadaka commented 10 years ago

Yeah unhandled exception and the app crashes. Not sure how the JSON response is but I doubt xbmc would return null in the response

akshay2000 commented 10 years ago

I don't remember right now, but I said it won't be null because I've explicitly set it to string.Empty whenever null could occur. Good catch!