search

akuity / kargo

Application lifecycle orchestration
https://kargo.akuity.io/
Apache License 2.0
1.82k stars 151 forks source link

Use builtin Kubernetes feature for gRPC health check #3038

Open hiddeco opened 1 week ago

hiddeco commented 1 week ago

Since Kubernetes 1.27 (available since April 2023), there is a built-in gRPC liveness probe available.

We should consider starting to use this to free ourselves from the dependency on grpc_health_probe, which we have to bake into our image (and keep updated).

hiddeco commented 1 week ago

@krancour @jessesuen what Kubernetes versions are we officially supporting? Anything that is not EOL?

krancour commented 1 week ago

It's not something we've formally established yet.

Anything that is not EOL?

That would be my vote, but that means v1.29+.

I defer to @jessesuen.

jessesuen commented 1 week ago

I think we can make the built-in probe the new default. The probes have seems to have been available in beta since v1.24, so we shouldn't break anyone.

hiddeco commented 1 week ago

As noted in #3041, we can not fully adopt this until Kubernetes starts to support TLS in the built-in probe.