NodeJS Version - Githubissues

borodatych commented 3 years ago

Issue type

I'm submitting a ... (check one with "x")

[ ] bug report
[x] feature request
[ ] question about the decisions made in the repository

Issue description

Current behavior: I had NodeJS 13.14.0 Failed to execute neither npm i nor npm ci

10240 error gyp ERR! cwd D:\Projects\Javascript\Angular\ngx-admin\node_modules\node-sass
10240 error gyp ERR! node -v v13.14.0
10240 error gyp ERR! node-gyp -v v7.1.2
10240 error gyp ERR! not ok
10240 error Build failed with error code: 1
10241 verbose exit 1

Current node-sass:

package.json
https://github.com/akveo/ngx-admin/blob/master/package.json#L65

package-lock.json
https://github.com/akveo/ngx-admin/blob/master/package-lock.json#L13748

https://github.com/sass/node-sass :

Below is a quick guide for minimum and maximum supported versions of node-sass:

NodeJS | Supported node-sass version | Node Module -- | -- | -- Node 16 | 6.0+ | 93 Node 15 | 5.0+ | 88 Node 14 | 4.14+ | 83 Node 13 | 4.13+, <5.0 | 79 Node 12 | 4.12+ | 72 Node 11 | 4.10+, <5.0 | 67 Node 10 | 4.9+, <6.0 | 64 Node 8 | 4.5.3+, <5.0 | 57 Node <8 | <5.0 | <57

NEED Node 12!! You didn't say a word about it ((

Expected behavior:

Some issues need review, and may require choosing
a different dependency.

Steps to reproduce:

$ node -v
v13.14.0
$ git clone https://github.com/akveo/ngx-admin.git
$ cd ngx-admin && npm i

Other information:

npm, node, OS, Browser

Node, npm: `v13.14.0` and `7.20.5`
OS: Windows 10 Home
Browser: Chrome

FARHANE commented 3 years ago

I have the same error

npm ERR! gyp ERR! cwd D:\workspace\metronic\ngx-admin\node_modules\node-sass
npm ERR! gyp ERR! node -v v14.17.5
npm ERR! gyp ERR! node-gyp -v v3.8.0
npm ERR! gyp ERR! not ok
npm ERR! Build failed with error code: 1

NeonSpork commented 3 years ago

I have the same error

npm ERR! gyp ERR! cwd D:\workspace\metronic\ngx-admin\node_modules\node-sass
npm ERR! gyp ERR! node -v v14.17.5
npm ERR! gyp ERR! node-gyp -v v3.8.0
npm ERR! gyp ERR! not ok
npm ERR! Build failed with error code: 1

@FARHANE, I just ran into this error actually. It turns out it wasn't node-gyp itself, but node-sass had an outdated version listed in its dependencies. I manually changed the specified version of node-gyp in the package-lock.json on line 13764 to "node-gyp": "^7.1.0",, after which the npm i command worked just fine!

Hope that helps!