alakajam-team / alakajam

Website powering the Alakajam! game making community
https://alakajam.com/
Other
28 stars 13 forks source link

Check for shortlist eliminations upon viewing the theme page rather than submitting votes #623

Open mkalam-alami opened 3 years ago

mkalam-alami commented 3 years ago

We can get minor glitches like the theme page displaying "the next theme will be eliminated in 11 hours", suggesting one has been just eliminated while it actually hasn't yet. Currently the elimination logic only triggers when someone saves their votes, which leads to unclear states like this.

Move await themeShortlistService.updateShortlistAutoElimination(event); to somewhere more appropriate (but ideally with some caching trick to avoid doing too many queries on every page view)