search

alan-turing-institute / bocpdms

MIT License
32 stars 12 forks source link

Add tests for EvaluationTool #5

Closed LouiseABowler closed 6 years ago

LouiseABowler commented 6 years ago

There aren't any unit tests for the BOCPDMS project at the moment, so let's start adding them before making any changes to the core classes. We could also do with a couple of end-to-end tests, based on the smallest examples.

LouiseABowler commented 6 years ago

There are now some unit tests (see 1a49cb4) around the stage where results stored in EvaluationTool are saved - a couple of them fail to highlight the issue I noticed when trying to save the results in the snowfall script.

I'll get those tests to pass now, and then I think this issue can be closed. We will need to add more unit tests but that should be done as we go along rather than in this specific issue.

LouiseABowler commented 6 years ago

Tests pass as of fea5414; the data stored by EvaluationTool is now labelled correctly. There are some clear opportunities for refectoring here, but that would involve updating all the plotting code - something to come back to rather than attempt right now.