alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io
BSD 3-Clause "New" or "Revised" License
57 stars 14 forks source link

Improve teardown reliability handling #1639

Open JimMadge opened 11 months ago

JimMadge commented 11 months ago

:white_check_mark: Checklist

:strawberry: Suggested change

Teardown may not be able to remove all resources. In that instance the CLI will give a non-zero return code.

We are not able to ensure that all resources are removed, that is out of our control. We might want to look at how often this happens, and if we can improve the handling/messaging.

:steam_locomotive: How could this be done?

jemrobinson commented 11 months ago

We currently retry on particular previously-encountered failures (where Azure doesn't correctly indicate that resource A can't be deleted until resource B has been). A better failure error message would certainly be a good idea.