Add pulumi tests - Githubissues

jemrobinson commented 4 months ago

:white_check_mark: Checklist

[x] You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
[x] You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
[x] Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

n/a

Adds some proof-of-concept Pulumi unit tests for the SRE ApplicationGateway component.

Note that much of what is described in the Pulumi documentation about Mocking does not seem to work with inline programs.

Important notes:

Pulumi Outputs should be tested within an apply loop with run_with_unknowns enabled, otherwise they will silently succeed on encountering any unknown values
Value-based assertions need to be defined separately (currently in resource_assertions.py) as raw assert cannot be used inside an apply loop
All tests must be decorated with pulumi.runtime.test or they will silently succeed
Any sub-resource that we want to test needs to be exposed as an attribute of the Component class (e.g. SREApplicationGateway now has self.application_gateway = ... in its constructor so that we can test the ApplicationGateway resource.

Closes #1835

github-actions[bot] commented 4 months ago

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
data_safe_haven/external/interface
azure_ipv4_range.py
data_safe_haven/infrastructure/common
transformations.py					16, 31, 39, 47, 80, 88, 96, 104, 112
data_safe_haven/infrastructure/programs/sre
application_gateway.py
tests/infrastructure/programs
resource_assertions.py					9-11
tests/infrastructure/programs/sre
conftest.py
test_application_gateway.py
Project Total