search

alan-turing-institute / setvis

A tool for visualising set membership and patterns of missingness in data
https://setvis.readthedocs.io
Apache License 2.0
4 stars 0 forks source link

Use jupyter exectute instead of papermill #108

Closed layik closed 1 year ago

layik commented 1 year ago

Testing jupyter execute on GH actions. Will request review before merge.

layik commented 1 year ago

Please let me know why we chose papermill @ots22. I will continue using jupyter execute whilst doing rename work at #106. I am still unable to get anything from GH actions as to why papermill hangs. I tried running it on macOS in #107

ots22 commented 1 year ago

I didn't know about jupyter execute - it looks like it had only just been added when we started using papermill, but good to know about. Papermill has a few extra features that we didn't end up needing.

If we care about keeping the output (not sure we do) then jupyter nbconvert --to notebook --execute {} is another option.

Interesting that papermill did seem to work on Actions for a short while before breaking, but it seems pretty hard to debug so given this works let's use it instead!

layik commented 1 year ago

Interesting that papermill did seem to work on Actions for a short while before breaking, but it seems pretty hard to debug so given this works let's use it instead!

Please feel free to edit the command.. So wont merge just yet.

ots22 commented 1 year ago

jupyter execute looks good, I'll merge