search

alan-turing-institute / setvis

A tool for visualising set membership and patterns of missingness in data
https://setvis.readthedocs.io
Apache License 2.0
4 stars 0 forks source link

Editorial changes for JOSS paper #142

Closed mstimberg closed 1 month ago

mstimberg commented 1 month ago

Some minor suggestions for changes to the JOSS paper in the context of openjournals/joss-reviews#6925

Please merge them in case you agree with them (no need to do a new release/archive, since only the paper is affected).

In addition, could you please consider making the following sentences more clear:

UpSetPlot crashed when the 500 000 row dataset contained more than 500 intersections. By contrast, SetVis only used 113 MB RAM for that dataset (see Figure 2A).

If I am not mistaken, the 113 MB RAM figure is for the 500 000 row dataset with 10000 set intersections, which in my opinion is not clear from the formulation "for that dataset".

layik commented 1 month ago

Thank you very much for the suggestions and I agree the 113 MB reference is not clear. I will add that to the joss branch rather than messing about multiple remotes to add it to this PR :) once I reference this PR will merge for convenience.

mstimberg commented 1 month ago

Sounds/looks good to me :+1: