search

alantrrs / OpenTLD

:eyes: C++ implementation of TLD
GNU General Public License v3.0
225 stars 99 forks source link

optimize #12

Closed yangxian closed 12 years ago

yangxian commented 12 years ago

I like your work, it is so cool. I think the function "filterPts" don't need to check "status" twice and the second check is wrong. And I find the function TLD::getOverlappingBoxes is not efficient.the nth_element waste much time, and the waste is not necessary. Best wish~

alantrrs commented 12 years ago

Hi, you are completely right about the 'status' issue. Thanks! How would you replace the nth_element function? I'm using nth_element instead of a full sort of the elements because I think it is faster but if you have any suggestion let me know.

yangxian commented 12 years ago

Hi, Thanks for your reply. I think nth_element is fast. But the structure OComparison is a little slow At 2011-12-30 03:43:09,"Alan Torres" reply@reply.github.com wrote:

Hi, you are completely right about the 'status' issue. Thanks! How would you replace the nth_element function? I'm using nth_element instead of a full sort of the elements because I think it is faster but if you have any suggestion let me know.

Reply to this email directly or view it on GitHub: https://github.com/alantrrs/OpenTLD/issues/12#issuecomment-3304363

alantrrs commented 12 years ago

Any suggestions to make it faster?

On Thu, Dec 29, 2011 at 6:12 PM, yangxian < reply@reply.github.com

wrote:

Hi, Thanks for your reply. I think nth_element is fast. But the structure OComparison is a little slow At 2011-12-30 03:43:09,"Alan Torres" reply@reply.github.com wrote:

Hi, you are completely right about the 'status' issue. Thanks! How would you replace the nth_element function? I'm using nth_element instead of a full sort of the elements because I think it is faster but if you have any suggestion let me know.

Reply to this email directly or view it on GitHub: https://github.com/alantrrs/OpenTLD/issues/12#issuecomment-3304363

Reply to this email directly or view it on GitHub: https://github.com/alantrrs/OpenTLD/issues/12#issuecomment-3307049

Alan I. Torres Nogales