Open alashworth opened 5 years ago
Issue by syclik Thursday Dec 29, 2016 at 05:30 GMT Originally opened as https://github.com/stan-dev/stan/issues/2195
These were issues that were noticed when code reviewing for #1751. @bob-carpenter spotted most of these.
gradient_samples
fullrank
meanfield
cont_params.resize(cont_vector.size());
Eigen::Map
@throw
@return
run()
v2.14.0
Summary:
These were issues that were noticed when code reviewing for #1751. @bob-carpenter spotted most of these.
Description:
gradient_samplesargument to the algorithm to something closer to "size of the sample" or "number of draws"fullrankandmeanfield, rather thancont_params.resize(cont_vector.size());, we should use anEigen::Map@throwand@returnproperly. Currently,run()looks like it can only return 0, but it does throw.Current Version:
v2.14.0