alaudet / raspi-sump

A sump pump monitoring system using Python and Raspberry Pi
https://www.linuxnorth.org/raspi-sump/
MIT License
92 stars 36 forks source link

Fixed issue #62: renamed create-mime.assign.pl to create-mime.conf.pl #63

Closed seanm closed 4 years ago

alaudet commented 4 years ago

Yes you are correct that lighttpd renamed the file.

It only affects users using Buster version of lighttpd. A temporary workaround is to also create a soft link, that way it does not affect all versions not using buster as well. I have documented this in the issue tracker.

https://github.com/alaudet/raspi-sump/issues/62

Changing it in the conf file will affect users on Stretch and Jessie so I can't merge this submitted change.

Also all changes need to be submitted against the devel branch and not master.

Good to check the guidelines before submitting a change.

https://github.com/alaudet/raspi-sump/blob/master/CONTRIBUTING.md

I will close this merge request for now but feel free to resubmit. I think the best way would be to add the line and comment it out with an explanation to uncomment if using Buster and to refer to the raspisump install documentation. I will likely make this change shortly anyway if you don't resubmit.

I really appreciate that your reported this. Thanks.