search

albertarielw / pe

0 stars 0 forks source link

Lacking duplicate detection #1

Open albertarielw opened 1 year ago

albertarielw commented 1 year ago

Steps to Reproduce:

enter the following commands: add -p n/abc a/123 p/1000 h/hdb add -p n/Abc a/123 p/1000 h/hdb

Expected:

either: Abc is considered a duplicate or give a warning that Abc maybe a duplicate and let user decide. Refer to guide on "Bugs related to duplicate detection" https://nus-cs2103-ay2223s1.github.io/website/admin/tp-pe.html#tp-practical-exam-pe

Actual:

no duplicate detected.

Screenshots

image.png

nus-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name field is case-sensitive

Expected: Suppose name "zanwen" is already in the data base, when adding another name "Zanwen", it should show an error message because "Zanwen" is already in the data base. Actual: It can add name "Zanwen" successfully, even though "zanwen" already exists.

image.png

[original: nus-cs2103-AY2223S1/pe-interim#5700] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Rejected because we meant for the feature to work this way.

For whatever reason, users might sometimes want properties with duplicate names and we decided to give them a way to do that.

As an example, perhaps a user has an existing condo named ‘Admiralty’ (the property's name is 'Admiralty'), and he wants to quickly add a random unit thats in the Admiralty region. This feature thus allow him to add a new property with 'admiralty' as its name and an address specific to that unit.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As per the requirements stated in CS2103T website, for this kind of duplicate names, there must be some form of acknowledgements or warning to users otherwise it is considered a bug.

You can check this link to clarify: https://nus-cs2103-ay2223s1.github.io/website/admin/tp-pe.html#pe-overview-2

image.png

:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]