albertqjiang / miniF2F

An updated version of miniF2F with problems fixed
0 stars 0 forks source link

Some other issues reported by Yutaka Nagashima and Daniel Sebastian #3

Open Wenda302 opened 2 years ago

Wenda302 commented 2 years ago
albertqjiang commented 2 years ago

Great job! This is very clear. Again I'll work bottom up and tick the tasks

albertqjiang commented 2 years ago

numbertheory_nckeqnm1ckpnm1ckm1 This problem does not match its name.

I don't understand this one. the name looks correct to me @Wenda302

albertqjiang commented 2 years ago
albertqjiang commented 2 years ago

mathd_numbertheory_155 The answer is 47.

The answer should be 48. I evaluated this and looked up the math dataset

albertqjiang commented 2 years ago

mathd_numbertheory_126 This problem also has a solution (x, a) = (37, 1480)

@Wenda302 how do you say that the smaller solution is ...?

albertqjiang commented 2 years ago

mathd_algebra_192 This problem also encodes complex numbers badly.

fixed but I don't think the original is "wrong"

Wenda302 commented 2 years ago

mathd_numbertheory_126 This problem also has a solution (x, a) = (37, 1480)

@Wenda302 how do you say that the smaller solution is ...?

We use the Least operator. I got this one :-)

Wenda302 commented 2 years ago

imo_2007_p6 was a silly mistake I overlooked in my previous skim-through. It is now fixed.

Wenda302 commented 2 years ago

aime_1997_p12, aimeI_2001_p3, and amc12a_2020_p22: the problem has also been noticed by Gary. Shall we rename the current .thy file & the theorem name? @albertqjiang

Wenda302 commented 2 years ago

It appears that you were considering Im 1 = \<i> or Im 7 = 7 * \<i> in Isabelle, Albert :-)

Wenda302 commented 2 years ago

@albertqjiang I pushed my fixes for problems from top to bottom until (and including) imo_1978_p5, plus mathd_numbertheory_126.

Wenda302 commented 2 years ago

numbertheory_nckeqnm1ckpnm1ckm1 This problem does not match its name.

I don't understand this one. the name looks correct to me @Wenda302

Ahh, me neither. I guess they mean the problem itself does not look like a number theory problem?

albertqjiang commented 2 years ago

aime_1997_p12, aimeI_2001_p3, and amc12a_2020_p22: the problem has also been noticed by Gary. Shall we rename the current .thy file & the theorem name? @albertqjiang

The naming problem has already been fixed

albertqjiang commented 2 years ago

It appears that you were considering Im 1 = \<i> or Im 7 = 7 * \<i> in Isabelle, Albert :-)

Wait is this not true?

albertqjiang commented 2 years ago

numbertheory_nckeqnm1ckpnm1ckm1 This problem does not match its name. I don't understand this one. the name looks correct to me @Wenda302

Ahh, me neither. I guess they mean the problem itself does not look like a number theory problem?

Let's leave this unchanged

Wenda302 commented 2 years ago

It appears that you were considering Im 1 = \<i> or Im 7 = 7 * \<i> in Isabelle, Albert :-)

Wait is this not true?

As both 1 and 7 are real numbers, their imaginary parts are zeros:Im 1 = Im 7 = 0...

albertqjiang commented 2 years ago

It appears that you were considering Im 1 = \<i> or Im 7 = 7 * \<i> in Isabelle, Albert :-)

Wait is this not true?

As both 1 and 7 are real numbers, their imaginary parts are zeros:Im 1 = Im 7 = 0...

Ah I see. So Im and Re are functions and not constructors of complex numbers....

DyeKuu commented 2 years ago

Hey @Wenda302 @albertqjiang , mathd_algebra_17 is reported as add the assumption 1 + a > 0.. I found that it's bcs in lean version there is real.sqrt (1+a) in it. and real.sqrt is truncated to 0 for negative number so that should be fine in lean. Don't know what's the case for Isabelle?

Wenda302 commented 2 years ago

Hmm, I think Lean is handling this better. In Isabelle, we have sqrt (-(2::real)) = - sqrt 2:-(

In this case, it is probably safer to add this extra assumption to the Isabelle version. I will PR.