search

albertz / music-player

Music player - endlessly plays your music
http://albertz.github.io/music-player/
BSD 2-Clause "Simplified" License
492 stars 59 forks source link

small hang at song switch when Cocoa GUI is opened #25

Closed albertz closed 11 years ago

albertz commented 11 years ago

I recognized a small hang just after a song switched when the GUI (Cocoa) is opened. This doesn't seem to happen when the GUI is not shown.

I guess the GUI updating code blocks the Python code for too long so that the player engine is blocked at some point when it needs the Python GIL.

There is nothing special in the log. Log header:

hello there
Error, argparse not available. This needs Python >=2.7.
MusicPlayer 1.0 from 2013-02-12 00:51:46 +0000 on MacOSX (darwin)
startup on 2013-02-12 02:02:14 +0000
albertz commented 11 years ago

Fixed in commit cf56bbbb9af4a29 (and related).