albrechtf / mcf2pdf

"My CEWE Photobook" MCF to PDF converter
Other
40 stars 37 forks source link

Improvement: Missing "imageDir" not catched/logged #9

Closed juocal closed 3 years ago

juocal commented 8 years ago

Hey there,

thank you for making this open source! It is working great so far! And it helped me to find my problem with this tool.

In Mcf2FoConverter you are getting the imageDir from the album. File imageDir = new File(baseDir, book.getImageDir());

Unfortunately, I just copied the mcf-File and not the adjacent folder. Thus, the output pdf file was just plain white, the images were missing. In the log files there was no hint what went wront.

I saw you commented the FileNotFoundException out, without writing a warning log or an error log.

Additional to that, it should be noted before rendering, that the directory referenced to in imageDir is missing.

That is just an propose for an improvement of the code and some people being frustrated ;)