search

alces-software / gridware

tool for compilation and installation of applications and libraries from the Alces Gridware software library
0 stars 0 forks source link

GitHub now signs commits - causes spaff when updating repos. #20

Closed RuanEllis closed 6 years ago

RuanEllis commented 6 years ago

GitHub now uses it's own key to sign commits when using the web interface - notably when using "Squash and Merge". This creates GPG signed commits into master which seemingly aren't handled by Clusterware. This is new (and seemingly unannounced) behaviour from GitHub - yay!

This can currently be seen by running alces gridware update with the volatile repository enabled. Updating volatile repo on (most?) Clusterware versions causes messages such as:

/opt/clusterware/lib/ruby/vendor/ruby/2.2.0/gems/grit-2.5.0/lib/grit/git-ruby/git_object.rb:254:in `block in from_raw' : unknown header 'gpgsig' in commit 9f9100a5e72132dcb6860d100d6cd8ea603d1951 (StandardWarning)
/opt/clusterware/lib/ruby/vendor/ruby/2.2.0/gems/grit-2.5.0/lib/grit/git-ruby/git_object.rb:254:in `block in from_raw' : unknown header '' in commit 9f9100a5e72132dcb6860d100d6cd8ea603d1951 (StandardWarning)
/opt/clusterware/lib/ruby/vendor/ruby/2.2.0/gems/grit-2.5.0/lib/grit/git-ruby/git_object.rb:254:in `block in from_raw' : unknown header '' in commit 9f9100a5e72132dcb6860d100d6cd8ea603d1951 (StandardWarning)
mjtko commented 6 years ago

Fixed in https://github.com/alces-software/gridware/releases/tag/20180215 with upgrade to rugged.