search

alces-software / gridware

tool for compilation and installation of applications and libraries from the Alces Gridware software library
0 stars 0 forks source link

Fix the Fixnum deprecation warning in ruby 2.5.1 #25

Closed WilliamMcCumstie closed 6 years ago

WilliamMcCumstie commented 6 years ago

With the update to flight direct and ruby 2.5.1, :Fixnum has been deprecated and issues a warning if used. However the DataObjects gem has been archived and probably will not make the update/ https://github.com/datamapper/do

This means running gridware on ruby 2.5.1 gives the following warning:

> flight gridware
/opt/flight-direct/opt/clusterware/opt/gridware/vendor/ruby/2.5.0/gems/data_objects-0.10.17/lib/data_objects/pooling.rb:149: warning: constant ::Fixnum is deprecated

As a temporary measure, this warning has been suppressed in flight (see: https://github.com/alces-software/forge-packages/commit/bcd7ec5b57662e437541fa6de2fccb2bf57fc858), however a more permanent fix would be better.

WilliamMcCumstie commented 6 years ago

This issue has been fixed in https://github.com/alces-software/gridware/pull/24/commits/28e86528cad5a9f2c335a8944f5d0da451a530a7