search

alchemy-fr / PHP-dataURI

A PHP dataURI library, RFC 2397 Compliant
Other
59 stars 25 forks source link

Update to handle OpenXML mimetypes #3

Closed funkjedi closed 10 years ago

funkjedi commented 10 years ago

For example: application/vnd.openxmlformats-officedocument.wordprocessingml.document

romainneutron commented 10 years ago

Thanks for your contribution ! Could you have a look at the comment I just wrote so I could merge your PR ?

nlegoff commented 10 years ago

You also should add a test against your mimetype

see https://github.com/alchemy-fr/PHP-dataURI/blob/master/tests/ParserTest.php#L35.

nlegoff commented 10 years ago

Fixed by https://github.com/alchemy-fr/PHP-dataURI/pull/4 Thanks