Build DataUri from remote URL

[zanardigit]

• get file from a remote URL via CURL and build a DataUri from it
• perform basic CURL response validation

Already included in unit tests. I just wasn't sure which remote image to use from test, so I improvised :-)

[fabre-thibaud]

Thanks for the P/R. Do you mind adding ext-curl as a dev requirement in composer.json and updating the documentation accordingly ?

[zanardigit]

@aztech-dev thank you for your quick reply! I've added the dependency to composer. Isn't the documentation supposed to be generated via phpDoc? Is that what you're asking me to do?

[fabre-thibaud]

Great. For documentation I was refering to https://github.com/alchemy-fr/PHP-dataURI/blob/master/docs/source/index.rst , but I can handle it if you want.

[zanardigit]

Oh, sure :-) Done. I also fixed two typos in the doc just a few lines above, hope you don't mind. Thank you.

[fabre-thibaud]

Thanks !

[zanardigit]

Eagerly waiting for a new release so I can issue a related PR here too: https://github.com/romainneutron/TwigExtension-DataUri

:-)

[zanardigit]

I apologize in advance for bothering you again... is there anything I can do to speed up the release of a new version with this enhancement included?

[fabre-thibaud]

Done :)

[zanardigit]

Thank you so much!

[fabre-thibaud]

No problem. I meant to do it after your P/R but I got distracted..