aldas / modbus-tcp-client

PHP client for Modbus TCP and Modbus RTU over TCP (can be used for serial)
Apache License 2.0
191 stars 55 forks source link

fix setting endian before creating request will create invalid request #144

Closed aldas closed 1 year ago

aldas commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 96.96% and project coverage change: -0.04 :warning:

Comparison is base (09bd467) 98.72% compared to head (fb0332c) 98.69%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #144 +/- ## ============================================ - Coverage 98.72% 98.69% -0.04% - Complexity 887 892 +5 ============================================ Files 69 69 Lines 2277 2291 +14 ============================================ + Hits 2248 2261 +13 - Misses 29 30 +1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `98.69% <96.96%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/aldas/modbus-tcp-client/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.) | Coverage Δ | | |---|---|---| | [src/Network/SerialStreamCreator.php](https://app.codecov.io/gh/aldas/modbus-tcp-client/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#diff-c3JjL05ldHdvcmsvU2VyaWFsU3RyZWFtQ3JlYXRvci5waHA=) | `93.75% <ø> (ø)` | | | [src/Network/BinaryStreamConnection.php](https://app.codecov.io/gh/aldas/modbus-tcp-client/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#diff-c3JjL05ldHdvcmsvQmluYXJ5U3RyZWFtQ29ubmVjdGlvbi5waHA=) | `96.29% <75.00%> (-1.71%)` | :arrow_down: | | [src/Network/BinaryStreamConnectionBuilder.php](https://app.codecov.io/gh/aldas/modbus-tcp-client/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#diff-c3JjL05ldHdvcmsvQmluYXJ5U3RyZWFtQ29ubmVjdGlvbkJ1aWxkZXIucGhw) | `100.00% <100.00%> (ø)` | | | [src/Network/BinaryStreamConnectionProperties.php](https://app.codecov.io/gh/aldas/modbus-tcp-client/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#diff-c3JjL05ldHdvcmsvQmluYXJ5U3RyZWFtQ29ubmVjdGlvblByb3BlcnRpZXMucGhw) | `100.00% <100.00%> (ø)` | | | [...Packet/ModbusFunction/MaskWriteRegisterRequest.php](https://app.codecov.io/gh/aldas/modbus-tcp-client/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#diff-c3JjL1BhY2tldC9Nb2RidXNGdW5jdGlvbi9NYXNrV3JpdGVSZWdpc3RlclJlcXVlc3QucGhw) | `100.00% <100.00%> (ø)` | | | [...acket/ModbusFunction/MaskWriteRegisterResponse.php](https://app.codecov.io/gh/aldas/modbus-tcp-client/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#diff-c3JjL1BhY2tldC9Nb2RidXNGdW5jdGlvbi9NYXNrV3JpdGVSZWdpc3RlclJlc3BvbnNlLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/Packet/ModbusFunction/ReadCoilsRequest.php](https://app.codecov.io/gh/aldas/modbus-tcp-client/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#diff-c3JjL1BhY2tldC9Nb2RidXNGdW5jdGlvbi9SZWFkQ29pbHNSZXF1ZXN0LnBocA==) | `100.00% <100.00%> (ø)` | | | [...ket/ModbusFunction/ReadHoldingRegistersRequest.php](https://app.codecov.io/gh/aldas/modbus-tcp-client/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#diff-c3JjL1BhY2tldC9Nb2RidXNGdW5jdGlvbi9SZWFkSG9sZGluZ1JlZ2lzdGVyc1JlcXVlc3QucGhw) | `100.00% <100.00%> (ø)` | | | [...acket/ModbusFunction/ReadInputDiscretesRequest.php](https://app.codecov.io/gh/aldas/modbus-tcp-client/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#diff-c3JjL1BhY2tldC9Nb2RidXNGdW5jdGlvbi9SZWFkSW5wdXREaXNjcmV0ZXNSZXF1ZXN0LnBocA==) | `100.00% <100.00%> (ø)` | | | [...acket/ModbusFunction/ReadInputRegistersRequest.php](https://app.codecov.io/gh/aldas/modbus-tcp-client/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.#diff-c3JjL1BhY2tldC9Nb2RidXNGdW5jdGlvbi9SZWFkSW5wdXRSZWdpc3RlcnNSZXF1ZXN0LnBocA==) | `100.00% <100.00%> (ø)` | | | ... and [8 more](https://app.codecov.io/gh/aldas/modbus-tcp-client/pull/144?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martti+T.) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.