search

alecjacobson / computer-graphics-ray-casting

Computer Graphics Assignment about Ray Casting
30 stars 28 forks source link

make error #20

Open FannieZhao0317 opened 5 years ago

FannieZhao0317 commented 5 years ago 
fatal erroe: Eigen/Core: No such file or directory 
#include <Eigen/Core>
Oscar-Liang commented 5 years ago

My eigen folder was empty when I cloned the directory, giving me the same problem, so you may need to also clone the Eigen library.

FannieZhao0317 commented 5 years ago

My eigen folder was empty when I cloned the directory, giving me the same problem, so you may need to also clone the Eigen library.

I tried cloning the Eigen library as well, it didn't work. For convenience I just changed every includes with Eigen to <eigen3/Eigen/..> and it temporarily fixed the problem.

Oscar-Liang commented 5 years ago

It won't compile when your code is being marked. Are the repo contents in the eigen folder, or are they in another folder inside the eigen folder? If it's the latter, then extract them from the folder.

FannieZhao0317 commented 5 years ago

It won't compile when your code is being marked. Are the repo contents in the eigen folder, or are they in another folder inside the eigen folder? If it's the latter, then extract them from the folder.

Thank! I will try putting them out. For the changes I made, they are all in "include" folder, for which we won't be submitting. So idk maybe it won't change what's gonna happen at computer lab's side?

FannieZhao0317 commented 5 years ago

Thank you! It worked.

abhimadan commented 5 years ago

It looks like you've got it working this time, but for future reference, either use git clone --recursive (instead of just git clone) when cloning the assignment repo, or if you forget, use git submodule update --init --recursive after you've cloned the repo. We include Eigen as a submodule of the assignment repo, so doing this puts the directory in a place we've written the cmake files to know about.