search

alecmev / trimless-gmail

Automatically shows trimmed content in Google Mail™
MIT License
15 stars 6 forks source link

Support new Gmail #38

Closed ICDeadPpl closed 5 years ago

ICDeadPpl commented 6 years ago

As detailed by abelter in this post: https://github.com/jeremejevs/trimless-gmail/issues/37#issuecomment-385285120

alecmev commented 6 years ago

Thank you for the contribution! @abelter said the following about this fix:

My change is causing it to repeatedly reload the clipped content.

Does it not do that anymore?

ianhyzy commented 5 years ago

Thank you for the contribution! @abelter said the following about this fix:

My change is causing it to repeatedly reload the clipped content.

Does it not do that anymore?

I tried his code, it does seem to work without repeated reloading.

alecmev commented 5 years ago

My understanding is that it happens only for a relatively rare subset of emails, but thanks for the data point, maybe Google has indeed changed something! @abelter Can you re-test, please?

alecmev commented 5 years ago

Decided to put this to rest, since nobody is stepping up. If anybody is curious, the issue was that the original "View entire message" link wasn't being removed from the page (unlike what was happening in the old Gmail), so it kept getting picked up by Trimless on every scan.

alecmev commented 5 years ago

Thanks to @abelter for identifying the problem and proposing a fix, to @ICDeadPpl for pushing this through, and to @ianhyzy for testing. Will publish shortly.