alefragnani / vscode-language-pascal

Pascal language extension for Visual Studio Code
MIT License
216 stars 47 forks source link

[BUG] - Paren comments (* do not properly auto-close #141

Closed CharlesAverill closed 8 months ago

CharlesAverill commented 9 months ago

Environment/version

Steps to reproduce

Paren comments (* are autoclosed with ) instead of *), likely because the textmate language is greedily matching ( first. Not sure if there's a fix for this, I haven't dealt with the xml form of tmlanguages before.

alefragnani commented 8 months ago

Hi @CharlesAverill ,

First of all, sorry for the late reply.

About the issue, in fact, I guess it is not related to .tmlanguage at all, as the auto closing pairs are defined in a separate file (pascal.configuration.json). Simply adding a new entry ["(*", "*)"], seems to work just fine.

It should be available in the next release.

Thanks for reporting

CharlesAverill commented 8 months ago

Thank you so much!

On Wed, Dec 27, 2023 at 9:50 PM Alessandro Fragnani < @.***> wrote:

Hi @CharlesAverill https://github.com/CharlesAverill ,

First of all, sorry for the late reply.

About the issue, in fact, I guess it is not related to .tmlanguage at all, as the auto closing pairs are defined in a separate file ( pascal.configuration.json). Simply adding a new entry ["(", ")"], seems to work just fine.

It should be available in the next release.

Thanks for reporting

— Reply to this email directly, view it on GitHub https://github.com/alefragnani/vscode-language-pascal/issues/141#issuecomment-1870797010, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDDM375EUBAFWUUGNJ7HTDYLTT6RAVCNFSM6AAAAABAQ5T3UCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZQG44TOMBRGA . You are receiving this because you were mentioned.Message ID: @.***>