search

alelievr / Mixture

Mixture is a powerful node-based tool crafted in unity to generate all kinds of textures in realtime
https://trello.com/b/2JiH2Vsp/mixture
MIT License
1.18k stars 124 forks source link

[BUG] "graph.onGraphChanges += ProcessGraphWhenChanged;" accumulates infinitely #30

Closed danholbertunity closed 3 years ago

danholbertunity commented 3 years ago

What happened? You can get into a situation where the graph runs an arbitrary number of times upon changes (instead of just one time).

To Reproduce Open a Mixutre graph. Close the graph editor. Open the same graph again. Attach a debugger and put a breakpoint in MixtureGraphProcessor.ProcessNodeList Make a change to your graph that would trigger it to run again. Notice that your breakpoint is hit twice. Close the graph editor and repeat the process. Notice that your breakpoint is hit three times. And so on.

Setup: Windows "version": "0.3.0", "unity": "2020.3",

alelievr commented 3 years ago

Thanks for the bug report, the fix seems straightforward, I'll fix it soon

alelievr commented 3 years ago

Fixed in https://github.com/alelievr/Mixture/commit/b5238bec0c13b9fb9c1abdb59fe5b13b5def1106

danholbertunity commented 3 years ago

Great. Thank you!

On Sat, Jun 26, 2021 at 2:32 PM Antoine Lelievre @.***> wrote:

Fixed in b5238be https://github.com/alelievr/Mixture/commit/b5238bec0c13b9fb9c1abdb59fe5b13b5def1106

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alelievr/Mixture/issues/30#issuecomment-869002642, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASLBQ232REJ4DCQI22QZ7KTTUXJH5ANCNFSM47J5KESA .