search

aleph-im / aleph-account

Aleph.im's Account management dApp
https://account.aleph.im/
2 stars 3 forks source link

Network errors (Github API, Websockets) do not fully break display #102

Closed BjrInt closed 1 year ago

BjrInt commented 1 year ago

The fix

Issues fetching the Github API do not break the dispay of the page anymore.

A warning is displayed if the API is unreachable and the version of the node is not marked as "latest/outdated/obsolete/..." Screenshot from 2023-05-24 12-49-12 Screenshot from 2023-05-24 12-49-05

How to replicate

If you're fortunate enough to have a steady connection to the API, you can block the network request manually in your browser devtools (head over to the network tab, right click on the request to Github displayed as "releases", and select "block URL")

Screenshot from 2023-05-24 12-50-17

Since this query is cached to avoid hitting Github rate limitting you might also have to clear your LocalStorage.

github-actions[bot] commented 1 year ago

Deployed (not pinned) on https://ipfs-2.aleph.im/ipfs/QmbgeaAiCoZMFwnrbdGJQHjvPjVhPL7qgUCpneum2XDBqS

moshemalawach commented 1 year ago

The warning should be specific on the fact that the checks are only disabled on the UI, not on the actual scoring.

github-actions[bot] commented 1 year ago

Deployed (not pinned) on https://ipfs-2.aleph.im/ipfs/QmeiYpPqVnqqypEBr99G7yGq1knz4awSFwyU667djZcuhj

github-actions[bot] commented 1 year ago

Deployed (not pinned) on https://ipfs-2.aleph.im/ipfs/QmSBFUaZTrLs5tSMRhqouV8PtnduW73R6UiUVFowrjPbyr