search

alesan99 / mari0_ae

Mari0: Alesan99's Entities
Do What The F*ck You Want To Public License
60 stars 24 forks source link

Fix platforms again #574

Open WilliamFr0g opened 11 months ago

WilliamFr0g commented 11 months ago

I fixed them already but alesan broke them so I had to fix them again

alesan99 commented 8 months ago

To be fair I did have you review my rewrite beforehand, and a rewrite was desperately needed.

I would prefer to keep the strings for side detection to be consistent with the terminology elsewhere, especially since I think that function is also used in the platform slope code, but I'm guessing you want accessible for a custom character thing?

WilliamFr0g commented 8 months ago

Your presentation of the rewrite was very confusing and I didn't understand that you'd changed it functionally. The numbers are just a little bit more compact since I can reverse them in one operation, having them doesn't break anything if you're concerned.