alex-gutev / cl-environments

Implements the CLTL2 environment access API.
https://alex-gutev.github.io/cl-environments/
MIT License
32 stars 6 forks source link

SBCL 2.3.10 Supports? #11

Closed hikettei closed 1 year ago

hikettei commented 1 year ago

If I run (ql:quickload :cl-environments) on SBCL 2.3.10, I encountered:

; caught ERROR:
;   READ error during COMPILE-FILE:
;   
;     Symbol "TRULY-DYNAMIC-EXTENT" not found in the SB-INT package.
;   
;       Line: 162, Column: 44, File-Position: 464[8](https://github.com/hikettei/cl-waffe2/actions/runs/6752601846/job/18358141750#step:7:9)
;   
;       Stream: #<SB-INT:FORM-TRACKING-STREAM for "file /home/runner/.roswell/lisp/quicklisp/dists/quicklisp/software/cl-environments-20211020-git/src/other/sbcl.lisp" {1003DBA453}>
Unhandled UIOP/LISP-BUILD:COMPILE-FILE-ERROR in thread #<SB-THREAD:THREAD tid=2622 "main thread" RUNNING
                                                          {10013E00[9](https://github.com/hikettei/cl-waffe2/actions/runs/6752601846/job/18358141750#step:7:10)3}>:
  COMPILE-FILE-ERROR while
  compiling #<CL-SOURCE-FILE "cl-environments" "src" "other/sbcl">

Backtrace for: #<SB-THREAD:THREAD tid=2622 "main thread" RUNNING {[10](https://github.com/hikettei/cl-waffe2/actions/runs/6752601846/job/18358141750#step:7:11)0[13](https://github.com/hikettei/cl-waffe2/actions/runs/6752601846/job/18358141750#step:7:14)E0093}>
0: (SB-DEBUG::DEBUGGER-DISABLED-HOOK #<UIOP/LISP-BUILD:COMPILE-FILE-ERROR {10042A1F93}> #<unused argument> :QUIT T)
1: (SB-DEBUG::RUN-HOOK *INVOKE-DEBUGGER-HOOK* #<UIOP/LISP-BUILD:COMPILE-FILE-ERROR {10042A1F93}>)
2: (INVOKE-DEBUGGER #<UIOP/LISP-BUILD:COMPILE-FILE-ERROR {10042A1F93}>)
3: (ERROR UIOP/LISP-BUILD:COMPILE-FILE-ERROR :CONTEXT-FORMAT "~/asdf-action::format-action/" :CONTEXT-ARGUMENTS ((#<ASDF/LISP-ACTION:COMPILE-OP > . #<ASDF/LISP-ACTION:CL-SOURCE-FILE "cl-environments" "src" "other/sbcl">)))
4: (UIOP/LISP-BUILD:CHECK-LISP-COMPILE-RESULTS NIL T T "~/asdf-action::format-action/" ((#<ASDF/LISP-ACTION:COMPILE-OP > . #<ASDF/LISP-ACTION:CL-SOURCE-FILE "cl-environments" "src" "other/sbcl">)))

I suspect that this is due to any API changes related to SBCL update since if I change to use SBCL2.3.9, everything goes well.

alex-gutev commented 1 year ago

I guess they removed that declaration. I will add a check for whether the symbol exists in the SB-INT package.

hikettei commented 1 year ago

I got that Thank you for your prompt reply!

alex-gutev commented 1 year ago

I added a check for the symbol in 1bd7ecf. Let me know if that fixes it (I don't have that version of SBCL at the moment).

hikettei commented 1 year ago

Confirmed that everything works on SBCL2.3.10:

image

the result obtained by running (asdf:test-system :cl-environments): image

Thanks