SyntaxError: Cannot use import statement outside a module

[NWYLZW]

Describe the bug

failed to load config from /Users/yijie/codes/projects/spirit/electron.vite.config.ts
error during start dev server and electron app:
/Users/yijie/codes/projects/spirit/node_modules/.pnpm/vite-plugin-glob-accept@0.1.0_@types+node@18.19.33_sass@1.77.2/node_modules/vite-plugin-glob-accept/dist/index.esm.js:1
import { posix, isAbsolute } from 'node:path';
^^^^^^

SyntaxError: Cannot use import statement outside a module

https://github.com/alex8088/electron-vite/blob/1838bdbf3ee91e5a0cd39840190ad2506edfd583/src/utils.ts#L78

 if (/\.m[jt]s$/.test(filePath)) {

Remove ts extension check, it can't be load esm when use ts extension.

Electron-Vite Version

2.2.0

Electron Version

28.2.0

Vite Version

5.0.12

Validations

• [X] Follow the Code of Conduct.
• [X] Read the Contributing Guidelines.
• [X] Read the docs.
• [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

[alex8088]

vite-plugin-glob-accept plugin problem, "type": "module" is not specified in package.json or name index.esm.js into index.esm.mjs.

[NWYLZW]

vite-plugin-glob-accept plugin problem, "type": "module" is not specified in package.json or name index.esm.js into index.esm.mjs.

I feel there's a bit of an issue. Why is it that even after setting up exports and module, it still continues to load as CommonJS (CJS), resulting in the outside module problem?

I'll take another look at the specific standards and behavior. I feel that directly assuming a file with a .ts extension to be ESM seems a bit strange.

[alex8088]

Whether the module is resolved as ESM or CJS can be determined by the type field of package.json or the file suffix.

However, since Electron does not support ESM before version 28, using the type field of package.json to support configuration file parsing comes at a cost. Of course, electron-vite is supported, but we cannot force developers to choose this option, and vite has such a requirement. On the other hand, most plugin distributions for Vite or Rollup are released as ESM, so it is intentional to parse ts configuration files into ESM.

In fact, there is an issue with the release of this plugin vite-plugin-glob-accept. If the configuration file suffix is changed to mts or mjs, this error will also occur. The reason has been mentioned earlier. Of course, if you change the configuration file to cts, there is no problem.

[NWYLZW]

Directly using vite.config.ts seems to be fine.

https://github.com/NWYLZW/recurrent-vite-config-load-ts/blob/239ab1c7ca7e80fc3b690250a70e0c78f571ecfc/vite.config.ts#L1-L8

[alex8088]

Directly using vite.config.ts seems to be fine.

https://github.com/NWYLZW/recurrent-vite-config-load-ts/blob/239ab1c7ca7e80fc3b690250a70e0c78f571ecfc/vite.config.ts#L1-L8

this way will use commonjs module. Try to add "type": "module" to your package.json will get the error.

[NWYLZW]

You are right.