fix: not using the mode from the config file - Githubissues

alex8088 / electron-vite

Next generation Electron build tooling based on Vite 新一代 Electron 开发构建工具，支持源代码保护

https://electron-vite.org

MIT License

3.57k stars 153 forks source link

fix: not using the mode from the config file #539

Closed krystianotto closed 5 months ago

krystianotto commented 5 months ago

Description

As described in #531 electron-vite does not take into account the mode entered from the configuration file. This PR fixes this issue.

Additional context

Following the documentation, the mode is taken first from --mode and then from the configuration, and the default is determined by the command.

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

alex8088 commented 5 months ago

@krystianotto Thanks, it will be merged after testing without problems.

krystianotto commented 5 months ago

@alex8088 Do you have a date for the upcoming release in which this fix will be included? Thanks!