alexa / alexa-skills-kit-sdk-for-python

The Alexa Skills Kit SDK for Python helps you get a skill up and running quickly, letting you focus on skill logic instead of boilerplate code.

https://developer.amazon.com/en-US/docs/alexa/alexa-skills-kit-sdk-for-python/overview.html

Apache License 2.0

812 stars 206 forks source link

Type hinting changes for mypy compatibility #140

Closed nikhilym closed 4 years ago

nikhilym commented 4 years ago

Description

This commit includes the following changes :

Add py.typed in manifest files, for including type stubs on dist files.
Added mypy.ini file with configurations
Made some generic class changes for mypy to realize the relationships bwn abstract and implemented classes
Added no-strict-optionals for some packages in mypy.ini, will enhance to remove them slowly

Motivation and Context

121

Testing

Tested manually by running mypy manually and installing the sdk's to check if type hinting is effected.

Screenshots (if appropriate)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[ ] I have added tests to cover my changes
[x] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license