alexbatalov / fallout2-ce

Fallout 2 for modern operating systems
Other
1.79k stars 123 forks source link

shift key #397

Closed Squabbywaboose closed 4 months ago

Squabbywaboose commented 5 months ago

Playing on iphone and no ability to highlight items with shift key.

manbehindthemadness commented 5 months ago

I am also noticing this on MacOs, the shift keys don't seem to work at all.

manbehindthemadness commented 5 months ago

Update: I actually retried this on a Ubuntu machine using Wine and the shift to hi light function didn't work there either. I am wondering if this is the base version of Fallout2 used, or a shared parameter of some kind...

xparaly commented 5 months ago

I'm on windows and my shift key does not highlight items either. If I launch Fallout2.exe, the shift key works as expected.

manbehindthemadness commented 5 months ago

After some experimentation I have discovered that this seems to be an issue loading the restoration project additions, I created a fully functioning install from the original cd on Ubuntu using wine, applied the restoration project, tested to confirm it was working, (had to install vulkan and open gl mesa, in addition to adding the draw exclusion environment variable). I then copied this directory to a MacBook and performed the fallout2-ce setup procedures. This resulted in an application crash when loading into the temple environment just after the white-screen transition. This could only be resolved by removing the gl_ammomod.int file from the scripts directory. On the second run the mouse stoped working in full-screen mode; however, the application didn't crash. Unfortunately the "magic rock" didn't appear in the temple environment indicating the modifications loaded successfully.

This was performed with the latest release binaries from both projects.

To summarize the above: there isn't a problem with the key-mapper, it's a problem loading the after market patches and mods, the shift-to-hilight functionality doesn't exist in the Fallout2 version 1.02 base image.

manbehindthemadness commented 5 months ago

Just to confirm that there wasn't some odd platform issue, I compiled the project from source. The issue remains. I think this will resolve itself as the sfall portions are added into the application support; however, we are out of luck until that happens.

phobos2077 commented 5 months ago

Maybe rename the issue. If it's really about missing keypress hook and not platform related.

manbehindthemadness commented 5 months ago

Maybe rename the issue. If it's really about missing keypress hook and not platform related.

What I am seeing is not a faulty keypress, this is a misleading take on my part: If I play the vanilla game v1.02, the shift key doesn't work regardless (at least not to outline items {this explains my observation in relation to the base image of the game, mine coming from the original CD}). If I install the Fallout Restoration Project (again using wine) The shift-to-outline functions work as expected in addition to the magic version rock in the temple environment. If I use this file structure as a base for fallout2-ce the game fails to load into the environments until the gl_ammomod.int script is removed; furthermore, when the game does indeed launch, the version rock is not present. This indicates to me that it's not a problem with the shift key, rather it's a problem with the original base image not using the shift key as seen in later distros in addition to the mods within the Fallout Restoration Project not being evaluated, thus, resulting in the observed behavior.

phobos2077 commented 5 months ago

"Shift to highlight" is mod feature, has nothing to do with the engine per se. So again, you need to clarify what this issue is about. If it's a platform support issue (shift not working on non-windows system) it's one thing. If it's just a missing sfall feature, it's another.

phobos2077 commented 4 months ago

Why are you editing one issue into completely different one? This confuses everyone.

manbehindthemadness commented 4 months ago

Why are you editing one issue into completely different one? This confuses everyone.

Incredibly bad practice. Editing a populated trouble report into a completely different issue just to close it out. Like WTH?